[UT] Remove potentially buggy SQL test case for mem_pool property of resource groups by arin-mirza · Pull Request #66104 · StarRocks/starrocks

arin-mirza · 2025-11-28T11:15:28Z

Why I'm doing:

I recently added E2E SQL test cases for testing the mem_pool property.

[UT] Add SQL tests for mem_pool property of resource groups #65859

One of the test cases has an incorrect regex.

show verbose resource groups all;
-- result:
[REGEX][^shared_resource_group_for_brad]
-- !result

The intention was to assert that the expression cannot be matched in the result.
It instead tries to match a single character that is not present in the brackets.
The correct regex should use a negative lookahead to implement the intended behavior.

The test case, however, does not fail, as the result coincidentally does not start with any of these characters.

What I'm doing:

The check is actually redundant, as we already assert that the resource group was not created in the previous check.
Instead of adding another complicated regex with negative lookaheads, I am simply removing it.

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Note

Removes an incorrect regex-based assertion and a duplicate show verbose resource groups all call from the mem_pool resource group test.

Tests (SQL mem_pool resource groups):
- Remove invalid regex assertion block from R/test_create_two_resource_groups_with_mem_pool_different_mem_limit that attempted to verify absence in show verbose resource groups all output.
- Simplify T/test_create_two_resource_groups_with_mem_pool_different_mem_limit by removing a duplicate show verbose resource groups all call, leaving a single invocation.

^{Written by Cursor Bugbot for commit eef6213. This will update automatically on new commits. Configure here.}

arin-mirza · 2025-11-28T12:48:16Z

The failing test case seems to be unrelated to my changes.

----------------------------------------------------------------------
XML: nosetests.xml
----------------------------------------------------------------------
Ran 1063 tests in 627.714s

FAILED (failures=1)
⌛️ Time spent:
👉🏻 UNSTABLE SQL TEST: 1
info: sql/test_alter_table/R/test_schema_change_and_insert_concurrent@test_schema_change_and_insert_concurrent
ERROR LOGFILE: 
test_schema_change_and_insert_concurrent.log
current_version()
main-3d0d09d
❌ Unstable case: sql/test_alter_table/R/test_schema_change_and_insert_concurrent@test_schema_change_and_insert_concurrent
Updated case to db: sql/test_alter_table/R/test_schema_change_and_insert_concurrent@test_schema_change_and_insert_concurrent (Namespace: unstable_case)
---------------------------------------------------------------------
Type: SQL-Tester
Name: sql/test_alter_table/R/test_schema_change_and_insert_concurrent@test_schema_change_and_insert_concurrent
URL: https://github.com/StarRocks/starrocks/actions/runs/19762687694/attempts/1
Time: 2025-11-28 20:39:53
Branch: main
Repo: StarRocks/starrocks
Delete historical records...
Upload info to oss...
Error: Process completed with exit code 1.

alvin-celerdata · 2025-11-28T19:02:40Z

@mergify rebase

mergify · 2025-11-28T19:02:48Z

rebase

☑️ Nothing to do, the required conditions are not met

Details

any of:
- #commits > 1 [📌 rebase requirement]
- #commits-behind > 0 [📌 rebase requirement]
- -linear-history [📌 rebase requirement]
-closed [📌 rebase requirement]
-conflict [📌 rebase requirement]
queue-position = -1 [📌 rebase requirement]

..._resource_group_mem_pool/R/test_create_two_resource_groups_with_mem_pool_different_mem_limit

alvin-celerdata · 2025-12-02T17:17:06Z

@cursor review

cursor

Bug: T file not updated to match R file changes

The R (result) file had a show verbose resource groups all; command and its result block removed, but the corresponding T (template) file at test/sql/test_resource_group_mem_pool/T/test_create_two_resource_groups_with_mem_pool_different_mem_limit still contains two show verbose resource groups all; commands at lines 22-23. This creates a mismatch where the T file expects two executions of this command but the R file only defines expected results for one, which will likely cause test failures or incorrect test behavior.

test/sql/test_resource_group_mem_pool/R/test_create_two_resource_groups_with_mem_pool_different_mem_limit#L24-L28

starrocks/test/sql/test_resource_group_mem_pool/R/test_create_two_resource_groups_with_mem_pool_different_mem_limit

Lines 24 to 28 in 712eeb3

    
           show verbose resource groups all; 
        
           -- result: 
        
           [REGEX]shared_resource_group_for_alex.+7.+55(\.\d+)?%.+NORMAL.+\(id=\d+,.+user=alex\)\s*(shared_pool_for_alex_and_brad) 
        
           -- !result

mergify · 2025-12-09T11:45:37Z

🧪 CI Insights

Here's what we observed from your CI run for eef6213.

🟢 All jobs passed!

But CI Insights is watching 👀

Signed-off-by: arin-mirza <a.mirza@celonis.com>

github-actions · 2025-12-09T13:25:10Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2025-12-09T13:25:11Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2025-12-09T13:28:01Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

alvin-celerdata · 2025-12-09T17:30:28Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no bugs!

github-actions · 2025-12-09T17:34:49Z

@Mergifyio backport branch-4.0

mergify · 2025-12-09T17:34:56Z

backport branch-4.0

✅ Backports have been created

Details

#66531 [UT] Remove potentially buggy SQL test case for mem_pool property of resource groups (backport #66104) has been created for branch branch-4.0

…resource groups (#66104) Signed-off-by: arin-mirza <a.mirza@celonis.com> (cherry picked from commit d36d837)

ghost · 2025-12-09T17:49:59Z

ignore backport check: 4.0.3

…resource groups (backport #66104) (#66531) Signed-off-by: arin-mirza <a.mirza@celonis.com> Co-authored-by: Arın Mirza <74715683+arin-mirza@users.noreply.github.com>

…resource groups (StarRocks#66104) Signed-off-by: arin-mirza <a.mirza@celonis.com>

github-actions bot added the title needs [type] label Nov 28, 2025

mergify bot assigned arin-mirza Nov 28, 2025

arin-mirza changed the title ~~Remove potentially buggy SQL test case for mem_pool property of resource groups~~ [BugFix] Remove potentially buggy SQL test case for mem_pool property of resource groups Nov 28, 2025

github-actions bot added 4.0 and removed title needs [type] labels Nov 28, 2025

arin-mirza force-pushed the rg-memory-pool-e2e-sql-test-small-fix branch from 0e32622 to 712eeb3 Compare November 28, 2025 11:35

alvin-celerdata changed the title ~~[BugFix] Remove potentially buggy SQL test case for mem_pool property of resource groups~~ [UT] Remove potentially buggy SQL test case for mem_pool property of resource groups Nov 28, 2025

alvin-celerdata reviewed Nov 28, 2025

View reviewed changes

..._resource_group_mem_pool/R/test_create_two_resource_groups_with_mem_pool_different_mem_limit Show resolved Hide resolved

cursor bot reviewed Dec 2, 2025

View reviewed changes

arin-mirza added 2 commits December 9, 2025 13:21

Remove potentially buggy test statement.

0208938

Signed-off-by: arin-mirza <a.mirza@celonis.com>

Remove potentially buggy test statement (from T file)

eef6213

Signed-off-by: arin-mirza <a.mirza@celonis.com>

arin-mirza force-pushed the rg-memory-pool-e2e-sql-test-small-fix branch from f6c99e1 to eef6213 Compare December 9, 2025 12:22

alvin-celerdata approved these changes Dec 9, 2025

View reviewed changes

cursor bot reviewed Dec 9, 2025

View reviewed changes

alvin-celerdata merged commit d36d837 into StarRocks:main Dec 9, 2025
65 checks passed

github-actions bot removed the 4.0 label Dec 9, 2025

mergify bot pushed a commit that referenced this pull request Dec 9, 2025

[UT] Remove potentially buggy SQL test case for mem_pool property of …

dccc4eb

…resource groups (#66104) Signed-off-by: arin-mirza <a.mirza@celonis.com> (cherry picked from commit d36d837)

mergify bot mentioned this pull request Dec 9, 2025

[UT] Remove potentially buggy SQL test case for mem_pool property of resource groups (backport #66104) #66531

Merged

23 tasks

github-actions bot added the 4.0-merged label Dec 9, 2025

arin-mirza mentioned this pull request Dec 12, 2025

[Enhancement] Extend 'show usage resource groups;' with mem_pool metrics #66690

Merged

23 tasks

EdwardArchive pushed a commit to EdwardArchive/starrocks that referenced this pull request Dec 12, 2025

[UT] Remove potentially buggy SQL test case for mem_pool property of …

39a8934

…resource groups (StarRocks#66104) Signed-off-by: arin-mirza <a.mirza@celonis.com>

mergify bot mentioned this pull request Dec 31, 2025

[Enhancement] Extend 'show usage resource groups;' with mem_pool metrics (backport #66690) #67412

Closed

23 tasks


	show verbose resource groups all;
	-- result:
	[REGEX]shared_resource_group_for_alex.+7.+55(\.\d+)?%.+NORMAL.+\(id=\d+,.+user=alex\)\s*(shared_pool_for_alex_and_brad)
	-- !result

Conversation

arin-mirza commented Nov 28, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

arin-mirza commented Nov 28, 2025

Uh oh!

alvin-celerdata commented Nov 28, 2025

Uh oh!

mergify bot commented Nov 28, 2025

☑️ Nothing to do, the required conditions are not met

Uh oh!

Uh oh!

alvin-celerdata commented Dec 2, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: T file not updated to match R file changes

Uh oh!

mergify bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

🟢 All jobs passed!

Uh oh!

github-actions bot commented Dec 9, 2025

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions bot commented Dec 9, 2025

[FE Incremental Coverage Report]

Uh oh!

github-actions bot commented Dec 9, 2025

[BE Incremental Coverage Report]

Uh oh!

alvin-celerdata commented Dec 9, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

✅ Bugbot reviewed your changes and found no bugs!

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

mergify bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

ghost commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arin-mirza commented Nov 28, 2025 •

edited by cursor bot

Loading

mergify bot commented Dec 9, 2025 •

edited

Loading

mergify bot commented Dec 9, 2025 •

edited

Loading